fix(cmap): undo flipping of beforeHandshake flag for timeout errors
#2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadum
requested review from
nbbeeken,
emadum,
a team and
durran
and removed request for
a team
Add a unit test to confirm this behavior doesn't regress
nbbeeken
approved these changes
May 20, 2021
There was a problem hiding this comment.
Hey Val, thanks so much for catching this I want to expedite this fix a bit so I've taken the liberty of adding regression tests and making a small change to the way the flag is set on the error class.
Also JIRA tracking: NODE-3305
dariakp
reviewed
May 21, 2021
- only define before handshake symbol if correct option is passed - clean up chai usage - rename tests - add tests for symbol defining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I ran into this issue when upgrading Mongoose to 3.6.7 (Automattic/mongoose#10265). 3.6.7 did some refactoring with f1afcc4 that seems to have unintentionally flipped the
beforeHandshakeflag on timeout errors. This causes the topology to always switch to 'Unknown' state when there's an operation timeout.What changed?
Undoing a change that I think may have been accidental.
Are there any files to ignore?