[v0.11 backport] Prevent overflow of runc exit code. #3902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for the Status field of runc.ExitError to be set to -1, in which case conversion to uint32 results in the error message to say that the container exited with code 4294967295 (2^32-1). Signed-off-by: Erik Sipsma <erik@sipsma.dev> (cherry picked from commit 9b0bdb6) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
neersighted
approved these changes
May 25, 2023
crazy-max
approved these changes
May 25, 2023
|
don't merge (yet); there was some discussion on this whether it's good to "hide the problem", without addressing the root-cause (second part of the linked PR) |
tonistiigi
requested changes
May 25, 2023
This was referenced May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for the Status field of runc.ExitError to be set to -1, in which case conversion to uint32 results in the error message to say that the container exited with code 4294967295 (2^32-1).
(cherry picked from commit 9b0bdb6)