Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not set connected before the connection is established with the server #8

Closed
rolandjitsu opened this issue May 13, 2014 · 2 comments

Comments

@rolandjitsu
Copy link

May I ask why is the self.connected set to YES when the method connectWithCompletionHandler:(void (^)(MQTTConnectionReturnCode code))completionHandler; is called on line 212 in MQTTKit.m?

I would expect that to only be set to true or false when a connection is made with the server or closed, not before is opened as it happens in this case. Or is that intended behaviour?

Anyway, great work and very useful 👍

@jmesnil
Copy link
Contributor

jmesnil commented May 14, 2014

that was a silly mistake (I've pushed a fix before I notice your PR).

Thanks for pointing it out

@rolandjitsu
Copy link
Author

No problem @jmesnil :) Just go ahead and close the other one as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants