"Group" is read when editor is focused

[isidorn]

Turn on VoiceOver, focus an editor
The following is read
"x editor, Editor Group 1 group".

1. group should not be read
2. Editor Group 1 should only be read if there is more than one group

fyi @ivanfetch

[isidorn]

Could not fix 1), since "group" is automatically read by VoiceOver. Suggestions on how to fix this are welcome.
2) I fixed, fyi @bpasero on my approach

Adding bug so we get this verified.
To verify: turn on screen reader and focus an editor, make sure the "Editor Group" is only read out if there is more than 1 group.

[bpasero]

@isidorn can we have a debt item for Feb to fix it properly? I think we are happily setting this:

this.editorContainer.setAttribute('aria-label', this.computeAriaLabel());

But we actually do not update the editor options ariaLabel property at all. Neither from group changes nor from label changes. In fact I think we are computing the aria label twice: /~https://github.com/microsoft/vscode/blob/master/src/vs/workbench/browser/parts/editor/textEditor.ts#L97

[bpasero]

PS: I even wonder if we should go back and not update the aria label on each label change in untitled editors. After all that might be very confusing for users that need screen readers. We could simply just set the Untitled-<N> thing and it would probably be fine.

[isidorn]

@bpasero Yeah, I was just copying what you were doing on the label change. I will create a debt item

As for untitled editors, having the aria label Untitled <N> makes perfect sense for me. Feel free to change that.

[sandy081]

@isidorn Group 1 is not read when there are more than one group

[isidorn]

We properly update the aria-label on the vscode side, however VoiceOver does not properly read the updated one.
However since we already have a debt item for this here #89621
I would prefer to keep this closed and as part of that debt work check if we can do something better

[isidorn]

Since @bpasero fixed this in the end, I have just verified it works fine, Thus adding verified label.