Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextEditorDecorators should also be rendered in minimap #73140

Closed
Colengms opened this issue May 1, 2019 · 5 comments
Closed

TextEditorDecorators should also be rendered in minimap #73140

Colengms opened this issue May 1, 2019 · 5 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-minimap Code/Text minimap widget issues feature-request Request for new features or functionality semantic-tokens Semantic tokens issues
Milestone
Backlog

Comments

@Colengms
Copy link
Contributor

Colengms commented May 1, 2019

How about rendering text decorators in the minimap? It looks like textmate colorization is applied, but decorators are not.

We'd like to colorize based on EDG parser results. We're investigating doing colorization programmatically from our extension using text decorators.
@vscodebot vscodebot bot added the editor-minimap Code/Text minimap widget issues label May 1, 2019
@RMacfarlane
Copy link
Contributor

Hey @Colengms, this looks similar to #20934. Please add any feedback to that issue. Thanks!

@RMacfarlane RMacfarlane added the *duplicate Issue identified as a duplicate of another issue(s) label May 1, 2019
@Colengms
Copy link
Contributor Author

Colengms commented May 3, 2019

I think this has been duped incorrectly. I am not requesting a new API to allow for adding decorators to the minimap. I am requested that text decorators added to the editor are also reflected propertly in the minimap (just as the textMate color are). Perhaps this is even a bug, not a feature request.

@Colengms Colengms mentioned this issue May 3, 2019
Closed
4 tasks
@aaron-bond aaron-bond mentioned this issue May 15, 2019
Open
@aaron-bond
Copy link

I think this has been closed incorrectly. I'm having the same issue with my Better Comments extension.
Is there some way to force a refresh of the minimap when drawing the decorators so that we could workaround the issue?

@Colengms Colengms changed the title Render text decorators in minimap TextEditorDecorators should also be rendered in minimap May 24, 2019
@RMacfarlane RMacfarlane reopened this Jun 10, 2019
@RMacfarlane RMacfarlane added feature-request Request for new features or functionality and removed *duplicate Issue identified as a duplicate of another issue(s) labels Jun 10, 2019
@Colengms Colengms mentioned this issue Jun 21, 2019
Closed
@alexdima alexdima added the semantic-tokens Semantic tokens issues label Aug 7, 2019
@Gruntfuggly Gruntfuggly mentioned this issue Oct 17, 2019
Closed
@RMacfarlane RMacfarlane self-assigned this Oct 24, 2019
@RMacfarlane RMacfarlane added this to the Backlog milestone Oct 24, 2019
@meakbiyik meakbiyik mentioned this issue Feb 17, 2020
Closed
@RMacfarlane RMacfarlane removed their assignment May 12, 2021
@hediet
Copy link
Member

hediet commented Nov 2, 2021 •
edited
Loading

/duplicate #82808 (which has more upvotes)

@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-minimap Code/Text minimap widget issues feature-request Request for new features or functionality semantic-tokens Semantic tokens issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@hediet @RMacfarlane @alexdima @aaron-bond @Colengms and others