Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header appears with a lag after sticky scroll has scrolled over it #191558

Closed
aiday-mar opened this issue Aug 29, 2023 · 2 comments
Closed

Header appears with a lag after sticky scroll has scrolled over it #191558

aiday-mar opened this issue Aug 29, 2023 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-sticky-scroll Sticky Scroll in Notebook Editor

Comments

@aiday-mar
Copy link
Contributor

aiday-mar commented Aug 29, 2023

Testing #191546

Hey @Yoyokrazy, great work here! I was testing the notebook sticky scroll and noticed the following behavior in the GIF. The header h5 - 1.2.2.2 appears when the bottom of the sticky widget is midway through the cell containing code. I think I would have expected the header to appear as soon as the bottom of header h4 in the sticky widget hits the top of the header h5 in the editor.

In this testing I am using the file sticky-test in your testing repo.

Screen.Recording.2023-08-29.at.09.17.02.mov
@aiday-mar aiday-mar changed the title Header appears to appear with a lag after sticky scroll has scrolled passed it Header appears with a lag after sticky scroll has scrolled over it Aug 29, 2023
@Yoyokrazy
Copy link
Contributor

Thanks for the gif! Yeah, this is something I've been working to address, and is a bit of work in progress. More fine-tuned transitions will likely come alongside animations as I fine tune the padding values I use to time the rendering.

@Yoyokrazy Yoyokrazy added the notebook-sticky-scroll Sticky Scroll in Notebook Editor label Aug 29, 2023
@Yoyokrazy Yoyokrazy added the bug Issue identified by VS Code Team member as probable bug label Dec 14, 2023
@Yoyokrazy
Copy link
Contributor

fixed via #201837

@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-sticky-scroll Sticky Scroll in Notebook Editor
Projects
None yet
Development

No branches or pull requests

2 participants