Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open workspace from vscode:// url #133976

Closed
rsargent opened this issue Sep 28, 2021 · 5 comments
Closed

Open workspace from vscode:// url #133976

rsargent opened this issue Sep 28, 2021 · 5 comments
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues

Comments

@rsargent
Copy link

I can open a workspace by specifying a .workspace file from the commandline:

code /path/to/my.workspace

I'd like to be able to open a workspace from a vscode: url like so:

vscode://file/path/to/my.workspace

Thanks for considering.

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Sep 28, 2021
@bpasero bpasero added this to the September 2021 milestone Sep 28, 2021
@bpasero bpasero added the workbench-multiroot Multi-root (multiple folders) issues label Sep 28, 2021
@bpasero
Copy link
Member

bpasero commented Sep 28, 2021

Looks like a bug to me that we do not handle this correctly atm. Something must have broken here given my comment.

//cc @joaomoreno on the fix

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Sep 30, 2021

Am I doing something wrong?

# works
code-insiders /Users/tyleonha/Code/Misc/multi-root-test/workspace.code-workspace

# doesn't work
code-insiders vscode://Users/tyleonha/Code/Misc/multi-root-test/workspace.code-workspace
code-insiders vscode:///Users/tyleonha/Code/Misc/multi-root-test/workspace.code-workspace

the path is odd... isn't it?
image

@TylerLeonhardt TylerLeonhardt added the verification-found Issue verification failed label Sep 30, 2021
@bpasero bpasero closed this as completed Oct 1, 2021
@bpasero
Copy link
Member

bpasero commented Oct 1, 2021

Yes, this is about link handlers, not CLI.

@bpasero bpasero added author-verification-requested Issues potentially verifiable by issue author and removed verification-found Issue verification failed labels Oct 1, 2021
@bpasero
Copy link
Member

bpasero commented Oct 1, 2021

@rsargent could you verify in insiders?

@rsargent
Copy link
Author

rsargent commented Oct 1, 2021

Confirmed! I installed

Version: 1.61.0-insider (Universal)
Commit: 83b7d33abba1fbc9ba6dbf25b53b47821086b22f
Date: 2021-09-30T18:59:55.207Z (14 hrs ago)
Electron: 13.5.0
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 19.6.0

and successfully opened a workspace with the vscode-insiders:// url variant by typing

vscode-insiders://file/path/to/my.workspace

into my web browser.

Thanks so very much for responding so incredibly quickly to the original report.

@bpasero bpasero added the verified Verification succeeded label Oct 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

No branches or pull requests

4 participants
@rsargent @bpasero @TylerLeonhardt and others