Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"here" of C_Cpp.files.exclude is not localized for zh-cn #7824

Closed
michelleangela opened this issue Jul 14, 2021 · 8 comments · Fixed by #12671
Closed

"here" of C_Cpp.files.exclude is not localized for zh-cn #7824

michelleangela opened this issue Jul 14, 2021 · 8 comments · Fixed by #12671
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service world ready An issue relating string character encodings, localization translations, etc.
Milestone

Comments

@michelleangela
Copy link
Contributor

Bug type: Language Service

image

@michelleangela michelleangela added bug Language Service world ready An issue relating string character encodings, localization translations, etc. labels Jul 14, 2021
@michelleangela michelleangela added this to the Tracking milestone Jul 15, 2021
@v-ericawu
Copy link

@michelleangela Tested on 1.14.1(pre-release) extension version, now the result is as follows:
"here" localized, while translation string missing for "Read more about glob patters":
CHS:
image

ENU:
image

@sean-mcmanus sean-mcmanus modified the milestones: Tracking, 1.22.3 Aug 30, 2024
@sean-mcmanus sean-mcmanus moved this to Pull Request in cpptools Aug 30, 2024
@github-project-automation github-project-automation bot moved this from Pull Request to Done in cpptools Aug 31, 2024
@sean-mcmanus
Copy link
Contributor

@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Sep 13, 2024
@bobbrow
Copy link
Member

bobbrow commented Sep 13, 2024

I changed the string, but did we get an updated translation for it yet? It looks like it's still English in the Loc PR which is still open.

@sean-mcmanus sean-mcmanus reopened this Sep 13, 2024
@sean-mcmanus
Copy link
Contributor

Ok, so maybe keep this open until we get the translation.

@sean-mcmanus
Copy link
Contributor

@Colengms Oh, but it's been 2 weeks -- shouldn't we have gotten the string translated by now? I don't see it translated in the loc branch. But I also didn't see any failure with the loc pipeline.

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Sep 13, 2024

It looks like the English strings (untranslated) got updated in the loc branch just 10 hours ago, so it looks like there's just some delay in the translations and we're getting updates still.

@sean-mcmanus sean-mcmanus modified the milestones: 1.22.3, 1.23.0 Oct 15, 2024
@sean-mcmanus sean-mcmanus moved this from Done to Todo in cpptools Oct 15, 2024
@sean-mcmanus
Copy link
Contributor

It looks like we still haven't gotten the translation yet (maybe for 1.23.0).

@sean-mcmanus sean-mcmanus modified the milestones: 1.23.0, 1.23 Oct 15, 2024
@sean-mcmanus sean-mcmanus modified the milestones: 1.23, 1.23.0 Oct 23, 2024
@sean-mcmanus sean-mcmanus moved this from Todo to Done in cpptools Oct 23, 2024
@bobbrow bobbrow closed this as completed Oct 29, 2024
@v-ericawu
Copy link

Verified on C/C++ 1.23.0 (pre-release), this bug has been fixed:

Language Verify Result 
CHS Image
CHT Image
CSY Image
DEU Image
ENU Image
ESN Image  
FRA Image
ITA Image
PLK Image
PTB Image
TRK Image
RUS Image
KOR Image
JPN Image

@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service world ready An issue relating string character encodings, localization translations, etc.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants