Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf: Slow LINQ Contains method being used #883

Closed
weltkante opened this issue Jul 31, 2021 · 0 comments · Fixed by #884
Closed

Perf: Slow LINQ Contains method being used #883

weltkante opened this issue Jul 31, 2021 · 0 comments · Fixed by #884

Comments

@weltkante
Copy link
Contributor

Bug description

JoinableTaskDependencyGraph.GetDependentTasksFromCandidates uses LINQ Contains instead of HashSet.Contains

Repro steps

Code inspection via VS intellisense shows LINQ Enumerable.Contains extension method being used:

if (candidates.Contains(startDepenentNode))

grafik
grafik
grafik

Expected behavior

Fast HashSet.Contains method should be used

Actual behavior

Slower LINQ enumeration is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make use of fast HashSet.Contains check weltkante/vs-threading
1 participant
@weltkante