Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export-validation-docs should accept another binary #2155

Closed
eddynaka opened this issue Nov 14, 2020 · 1 comment · Fixed by #2156
Closed

export-validation-docs should accept another binary #2155

eddynaka opened this issue Nov 14, 2020 · 1 comment · Fixed by #2156

Comments

@eddynaka
Copy link
Collaborator

Today, the command export-validation-docs does not accept an external assembly containing rules.

Suggestion

Create a new property that can point to an assembly which contains rules, for example, binskim.rules.dll. With that, we would be able to generate any rules from any provider who implement the Skimmer class. If the property was not supplied, so it will warn or use the self assembly (just the way we have now).

@michaelcfanning

@michaelcfanning
Copy link
Member

Change verb name to export-docs. This should pick up a default assembly to operate against (do we need to provide an API stub for this property?) Then we can add an argument that overrides this value. We could support passing multiple assemblies...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants