Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better typings for Array.concat(), etc. #33645

Closed
wants to merge 3 commits into from
Closed

Better typings for Array.concat(), etc. #33645

wants to merge 3 commits into from

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Sep 27, 2019 •
edited
Loading

Roll up #33606, #33620 and #33630

Fixes #19535
Fixes #24579
Fixes #26378
Fixes #26976
Fixes #29604
Fixes #31033

@jablko jablko mentioned this pull request Sep 27, 2019
Closed
@jablko jablko force-pushed the patch-13 branch 5 times, most recently from 7cf1280 to b23d8ad Compare September 30, 2019 01:29
@jablko jablko changed the title Better typings for Array.concat() and .flatMap() Better typings for Array.concat(), etc. Sep 30, 2019
@jablko jablko force-pushed the patch-13 branch 9 times, most recently from 684dc5d to ee4c5e6 Compare October 7, 2019 14:31
@jablko jablko force-pushed the patch-13 branch 2 times, most recently from 98115c4 to a448f91 Compare October 16, 2019 14:46
@jablko jablko force-pushed the patch-13 branch 2 times, most recently from 0e26a78 to 6b277e3 Compare October 19, 2019 18:33
@jablko jablko force-pushed the patch-13 branch 3 times, most recently from 97d14d8 to 0faa4ed Compare November 17, 2019 14:28
@jablko
Copy link
Contributor Author

jablko commented Nov 17, 2019

@typescript-bot test this
@typescript-bot run dt
@typescript-bot user test this

@orta
Copy link
Contributor

orta commented Nov 18, 2019

@typescript-bot test this
@typescript-bot run dt
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 18, 2019 •
edited
Loading

Heya @orta, I've started to run the extended test suite on this PR at 032ede6. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 18, 2019 •
edited
Loading

Heya @orta, I've started to run the parallelized Definitely Typed test suite on this PR at 032ede6. You can monitor the build here. It should now contribute to this PR's status checks.

@RyanCavanaugh
Copy link
Member

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 31, 2020 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 0056e90. You can monitor the build here. It should now contribute to this PR's status checks.

This was referenced Jan 31, 2020
Closed
Closed
Open
@sandersn sandersn added the For Backlog Bug PRs that fix a backlog bug label Feb 1, 2020
@jablko
Copy link
Contributor Author

jablko commented Feb 3, 2020

@RyanCavanaugh Thanks! Could I please trouble you to trigger @typescript-bot run dt as well?

@RyanCavanaugh
Copy link
Member

@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 3, 2020 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at 77844cc. You can monitor the build here. It should now contribute to this PR's status checks.

@jablko jablko force-pushed the patch-13 branch 2 times, most recently from 43679d2 to 1c95e0e Compare February 4, 2020 18:52
@jablko jablko force-pushed the patch-13 branch 2 times, most recently from 8efba07 to 1e82814 Compare February 13, 2020 15:42
@sandersn
Copy link
Member

sandersn commented Mar 9, 2020

@DanielRosenwasser we should probably discuss this in a design meeting after we get an analysis of how breaky it is to user/DT/RWC tests. Though maybe we should hold this until after the existing effort to gather broken Array examples is done.

@sandersn sandersn self-assigned this Mar 10, 2020
@ljharb
Copy link
Contributor

ljharb commented Jan 8, 2022

Any update on this? I'm hoping it allows for idiomatic usage of eg [].concat(a || [], b || []).

@sandersn
Copy link
Member

sandersn commented Mar 3, 2022

This has been sitting for a long time, and a big part of that is the difficulty in making any change to array types. I think it has to be a single major update like #36554 nowadays. I'm going to close this PR, although it may be useful as a basis for a part of that work.

@sandersn sandersn closed this Mar 3, 2022
@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #19535. If you can get it accepted, this PR will have a better chance of being reviewed.

@tychenjiajun tychenjiajun mentioned this pull request Mar 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sandersn sandersn

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
6 participants
@jablko @orta @typescript-bot @RyanCavanaugh @sandersn @ljharb