Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically generating getter and setter #12417

Closed
waderyan opened this issue Nov 21, 2016 · 8 comments
Closed

Automatically generating getter and setter #12417

waderyan opened this issue Nov 21, 2016 · 8 comments
Labels
Domain: Refactorings e.g. extract to constant or function, rename symbol Fixed A PR has been merged for this issue Suggestion An idea for TypeScript VS Code Tracked There is a VS Code equivalent to this issue
Milestone
TypeScript 2.9

Comments

@waderyan
Copy link

From @user414 on April 24, 2016 12:39

I couldn't find this issue already existing. I was starting to make variable public just to avoid the setter/getter manual writing, I knew it was time to look for something. Luckily someone beat me to it

https://marketplace.visualstudio.com/items?itemName=DSKWRK.vscode-generate-getter-setter

perhaps this code can be integrated in the mainline, or use as a basis for this new functionality.

Copied from original issue: microsoft/vscode#5716
@waderyan waderyan self-assigned this Nov 21, 2016
@waderyan
Copy link
Author

From @dbaeumer on November 15, 2016 19:0

@waderyan this should come from the TS team.

@waderyan waderyan mentioned this issue Nov 21, 2016
Closed
@waderyan waderyan added VS Code Tracked There is a VS Code equivalent to this issue and removed code-actions labels Nov 21, 2016
@waderyan waderyan removed their assignment Nov 21, 2016
@mhegazy mhegazy added Suggestion An idea for TypeScript Domain: Refactorings e.g. extract to constant or function, rename symbol labels Nov 21, 2016
@DrewLandgrave
Copy link

Has there been any movement on this?

@mhegazy mhegazy mentioned this issue Feb 6, 2017
Closed
@mjbvz mjbvz mentioned this issue May 8, 2017
Closed
@arielalvarez88
Copy link

+1, pretty please

@davidmach14
Copy link

+1 I'm surprised it's not yet done...

1 similar comment
@JianboYan
Copy link

+1 I'm surprised it's not yet done...

@Kingwl
Copy link
Contributor

Kingwl commented Feb 22, 2018

should this issue for community milestone? @mhegazy

@mhegazy mhegazy added this to the Community milestone Feb 22, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Feb 22, 2018

got for it @Kingwl

@Kingwl Kingwl mentioned this issue Feb 23, 2018
Merged
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Apr 3, 2018
@mhegazy mhegazy modified the milestones: Community, TypeScript 2.9 Apr 3, 2018
@ghost ghost closed this as completed in #22143 Apr 10, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Apr 10, 2018

thanks @Kingwl!

@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Domain: Refactorings e.g. extract to constant or function, rename symbol Fixed A PR has been merged for this issue Suggestion An idea for TypeScript VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Milestone
TypeScript 2.9
Development

No branches or pull requests
7 participants
@arielalvarez88 @waderyan @DrewLandgrave @davidmach14 @Kingwl @mhegazy @JianboYan