New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add GSL_* prefix to VS_ADD_NATIVE_VISUALIZERS #934

Closed

ghost opened this issue Oct 9, 2020 · 1 comment · Fixed by #941

ghost commented Oct 9, 2020

Without this necessary prefix this cache variable goes to the ungrouped entries category.

Here is an example picture:

This is confusing for cmake-gui/ccmake users.

Instead the issue will be fixed if the cache variable is renamed to GSL_VS_ADD_NATIVE_VISUALIZERS.

Contributor

JordanMaples commented Oct 19, 2020

This seems like a pretty straight forward fix, please file a PR with the fix. Thanks.

JordanMaples mentioned this issue

added GSL_ prefix to VS_ADD_NATIVE_VISUALIZERS #941

Merged

JordanMaples closed this as completed in #941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment