Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Jansi for Windows #206

Closed
sdelamo opened this issue May 1, 2020 · 2 comments
Closed

Disable Jansi for Windows #206

sdelamo opened this issue May 1, 2020 · 2 comments
Assignees
@jameskleeh
Labels
type: bug Something isn't working
Milestone
2.0.1

Comments

@sdelamo
Copy link
Contributor

sdelamo commented May 1, 2020

See: micronaut-projects/micronaut-core#1521

See: https://twitter.com/simas_ch/status/1256125128544604161?s=20
@sdelamo sdelamo added the type: bug Something isn't working label May 1, 2020
@sdelamo sdelamo added this to the 2.0.1 milestone May 1, 2020
@sdelamo
Copy link
Contributor Author

sdelamo commented May 1, 2020

At CLI we can detect the user's environment and disable Jansi for Windows. What about the website? Should we disable jansi by default if the operating system cannot be detected? I think disabled by default unless MacOS or Linux is detected.

@sdelamo
Copy link
Contributor Author

sdelamo commented May 1, 2020

Maybe user agent can be leverage to detect OS

@jameskleeh jameskleeh self-assigned this May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jameskleeh jameskleeh

Labels
type: bug Something isn't working
Projects
None yet
Milestone
2.0.1
Development

No branches or pull requests
2 participants
@sdelamo @jameskleeh