Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: Don't cache query results for impersonated users #53532

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Backport: Don't cache query results for impersonated users #53532

merged 1 commit into from
Feb 11, 2025

Conversation

johnswanson
Copy link
Contributor

@johnswanson johnswanson requested a review from camsaul as a code owner February 11, 2025 12:57
@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label Feb 11, 2025
@johnswanson johnswanson changed the title Don't cache query results for impersonated users Backport: Don't cache query results for impersonated users Feb 11, 2025
@johnswanson johnswanson force-pushed the jds/cache-impersonation-51 branch from 3eade22 to 96dcf01 Compare February 11, 2025 13:05
@trunk-io Trunk.io
Copy link

trunk-io bot commented Feb 11, 2025 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

Flaky Test Failure Summary Logs
pk-auth-custom-role-e2e-test failure_text: snowflake_test.clj:477:snowflakeCreated database is correctly syncedApplication database contains one database, one table and one n... Logs ↗︎
conn-impersonation-test-snowflake The test failed because the database does not exist or is not authorized for the given query. Logs ↗︎

View Full Report ↗︎ ⋅ Docs

@johnswanson johnswanson merged commit e966c57 into release-x.51.x Feb 11, 2025
131 of 132 checks passed
@johnswanson johnswanson deleted the jds/cache-impersonation-51 branch February 11, 2025 15:17
@github-actions github-actions bot added this to the 0.51.13 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahmoss noahmoss noahmoss approved these changes

@camsaul camsaul Awaiting requested review from camsaul camsaul is a code owner

Assignees

@johnswanson johnswanson

Labels
.Team/AdminWebapp Admin and Webapp team
Projects
None yet
Milestone
0.51.13
Development

Successfully merging this pull request may close these issues.
2 participants
@johnswanson @noahmoss