Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve custom remark config on parsing #337

Merged
merged 1 commit into from
Aug 21, 2021
Merged

feat: resolve custom remark config on parsing #337

merged 1 commit into from
Aug 21, 2021

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Aug 21, 2021

close #336

@JounQin JounQin added 🦋 type/enhancement This is great to have 🏡 area/internal This affects the hidden internals 🧒 semver/minor This is backwards-compatible change labels Aug 21, 2021
@JounQin JounQin self-assigned this Aug 21, 2021
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2021

Codecov Report

Merging #337 (478660c) into master (0feb2d3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #337   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          510       507    -3     
  Branches       110       109    -1     
=========================================
- Hits           510       507    -3     
Impacted Files Coverage Δ
packages/eslint-mdx/src/index.ts 100.00% <100.00%> (ø)
packages/eslint-mdx/src/parser.ts 100.00% <100.00%> (ø)
packages/eslint-mdx/src/processor.ts 100.00% <100.00%> (ø)
packages/eslint-plugin-mdx/src/rules/remark.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0feb2d3...478660c. Read the comment docs.

@JounQin JounQin merged commit 94fcb4c into master Aug 21, 2021
@JounQin JounQin deleted the fix/336 branch August 21, 2021 09:55
@JounQin
Copy link
Member Author

JounQin commented Aug 21, 2021

@wooorm Ready for a new release.

@wooorm
Copy link
Member

wooorm commented Aug 21, 2021

Are the tests supposed to take 150 seconds and more? They seem to hang for me on remark.test.ts and fixtures.test.ts?

@wooorm
Copy link
Member

wooorm commented Aug 21, 2021

jest is doing this sometimes for me, I’m not sure why. But running yarn again solved it 🤷‍♂️. Released!

@JounQin
Copy link
Member Author

JounQin commented Aug 21, 2021

jest is doing this sometimes for me, I’m not sure why. But running yarn again solved it 🤷‍♂️. Released!

The dependencies tree changed a bit in this PR, so yarn install is required. 🤣

@wooorm
Copy link
Member

wooorm commented Aug 21, 2021

I never have projects locally, nor yarn, so I installed both freshly though?

@JounQin
Copy link
Member Author

JounQin commented Aug 21, 2021

Then I'm not sure what is happening too. 🤣


I'm not sure why, but it seems build is required before test again, it should work without build before...

Maybe look into this tomorrow or later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏡 area/internal This affects the hidden internals 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

frontmatter is targeted
3 participants