Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete subscriptions upon user disconnect #34

Closed
mickmister opened this issue Feb 7, 2020 · 0 comments · Fixed by #42
Closed

Delete subscriptions upon user disconnect #34

mickmister opened this issue Feb 7, 2020 · 0 comments · Fixed by #42
Labels
Difficulty/1:Easy Easy ticket Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature

Comments

@mickmister
Copy link
Contributor

Summary

Currently, the disconnect functionality only removes the user from the KV store, and does not do anything on Microsoft's side. If the user has an active subscription, we should delete it in the KV store, as well as on Microsoft's side so we don't receive unnecessary webhook events.

Info on deleting a subscription using the Microsoft Graph API: https://docs.microsoft.com/en-us/graph/api/subscription-delete?view=graph-rest-1.0&tabs=http
@mickmister mickmister added Enhancement Difficulty/1:Easy Easy ticket Help Wanted Community help wanted Tech/Go Up For Grabs Ready for help from the community. Removed when someone volunteers labels Feb 7, 2020
@hanzei hanzei changed the title Help Wanted: Delete subscriptions upon user disconnect Delete subscriptions upon user disconnect Feb 20, 2020
@MatthewDorner MatthewDorner mentioned this issue Mar 3, 2020
Merged
@hanzei hanzei added Type/Enhancement New feature or improvement of existing feature and removed Up For Grabs Ready for help from the community. Removed when someone volunteers Enhancement labels Mar 4, 2020
@levb levb closed this as completed in #42 Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty/1:Easy Easy ticket Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete subscription upon disconnecting user MatthewDorner/mattermost-plugin-mscalendar
2 participants
@mickmister @hanzei