Migrate from Buildkite to GitHub actions #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
richvdh
approved these changes
Oct 31, 2022
.github/workflows/linting.yaml
Outdated
| - uses: actions/checkout@v3 | ||
| with: | ||
| fetch-depth: 0 | ||
| # checkout all branches; we only want origin/master, required to allow towncrier to diff |
There was a problem hiding this comment.
checkout all branches
we only want origin/master
aren't these mutually contradictory?
There was a problem hiding this comment.
the action is not doing a shallow copy; we only actually wanted & master, but this is the easy way to get it.
Adjust comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implements the buildkite tests in GHA. LIke for like at the moment; have removed the specific scripts for buildkite as GHA allows in-repo editing of them. Have left the linting script alone as it's also used for local linting purposes.
Note: Buildkite test failures are expected as part of this PR tidies up the old buildkite scripts.