Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for playing files without adding to the library #155

Open
YurySolovyov opened this issue Aug 17, 2016 · 12 comments · Fixed by #782
Open

Support for playing files without adding to the library #155

YurySolovyov opened this issue Aug 17, 2016 · 12 comments · Fixed by #782

Comments

@YurySolovyov
Copy link
Collaborator

YurySolovyov commented Aug 17, 2016

It should be possible to play selected (possibly multiple) files via:

right click -> open with -> museeks

Related: #154

@martpie martpie added this to the 0.8 milestone Sep 15, 2016
@martpie martpie mentioned this issue Sep 21, 2016
18 tasks
@martpie martpie removed this from the 0.8 milestone Dec 1, 2016
@aleclarson
Copy link

I would really like to have this. 😄

@YurySolovyov
Copy link
Collaborator Author

@KeitIG
In addition to the OP, I thought about adding files to playlists without going through library, what do you think if we add context menu to the + button with 3 items "From files", "From folders", "From library" ?

@YurySolovyov
Copy link
Collaborator Author

Sort of like in #248, we can also drop files(or folders, or mixed) on playlist area to add them to playlist.

@martpie
Copy link
Owner

martpie commented Apr 15, 2018

Currently working on this, but the documentation on file association is terrible, and testing it is tough too.

@martpie
Copy link
Owner

martpie commented Apr 15, 2018

https://electronjs.org/docs/api/app#event-open-file-macos for macOS, parse process.argv for linux/win.

@BlueManCZ
Copy link

Any progress in this?

On Linux, this functionality is handled by MimeType record in .desktop file:

...
...
MimeType=audio/mp1;audio/mp2;audio/mp3;

for example. List of MimeTypes would be probably longer. But it also has to be implemented in binary itself, to provide functionality to run command like this:

./museeks myfile.mp3

This could add this file into the library and play it, or just play it if it's already in the library.

@martpie
Copy link
Owner

martpie commented Mar 27, 2020

The problem is not too hard in terms of OS integration. It's about how the app works itself.

Currently, you can only play music that is in your library. In order to make it work, I need to add support to play files without them being in the library.

@BlueManCZ
Copy link

I like ideology in Clementine music player. When you open file from the file manager, it is added into your library no matter what. You can then remove it if you don't want it there.

@martpie
Copy link
Owner

martpie commented Mar 27, 2020

I like ideology in Clementine music player. When you open file from the file manager, it is added into your library no matter what. You can then remove it if you don't want it there.

maybe this is the solution yes, I feel it's weird though. imo it should play the title without adding it, it feels more natural.

@BlueManCZ
Copy link

it should play the title without adding it

But then you can't fill your library by opening files from the file manager. In Clementine, you can do this. Maybe solution would be adding "File open behaviour" into the settings.

@qcasey
Copy link
Contributor

qcasey commented Mar 27, 2020

Maybe solution would be adding "File open behaviour" into the settings.

Paired with a dialog prompting the user to set this when first doing ./museeks song.mp3, I think would be viable...

"Should files opened by Museeks be added to the Library?"

@martpie martpie added this to the 0.20 milestone Sep 8, 2024
This was referenced Sep 15, 2024
@martpie martpie reopened this Oct 1, 2024
@martpie
Copy link
Owner

martpie commented Oct 6, 2024

Progress tracker:

  • When the app starts
    • macOS
    • windows
    • Linux
  • When the app is already running
    • macOS
    • windows
    • Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants