Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finviz has changed the width of a td #154

Closed
jacobstac opened this issue Mar 28, 2023 · 2 comments
Closed

finviz has changed the width of a td #154

jacobstac opened this issue Mar 28, 2023 · 2 comments

Comments

@jacobstac
Copy link

Hi!
I don't know if its the correct way to write here, but here goes nothing : I got an error using your package version 1.4.5

File "/Users/........./venv/lib/python3.10/site-packages/finviz/helper_functions/scraper_functions.py", line 48, in get_total_rows etree.tostring(total_element[0]).decode("utf-8").split("</b>")[1].split()[0] IndexError: list index out of range

seems like finviz changed the width of the td from 140 to 128
so changing it line 44 in scraper_functions.py locally solved the issue for me locally.

@jacobstac jacobstac changed the title finviz has changed the widht of a td finviz has changed the width of a td Mar 28, 2023
@TyrionSnow1911
Copy link

Hi! I don't know if its the correct way to write here, but here goes nothing : I got an error using your package version 1.4.5

File "/Users/........./venv/lib/python3.10/site-packages/finviz/helper_functions/scraper_functions.py", line 48, in get_total_rows etree.tostring(total_element[0]).decode("utf-8").split("</b>")[1].split()[0] IndexError: list index out of range

seems like finviz changed the width of the td from 140 to 128 so changing it line 44 in scraper_functions.py locally solved the issue for me locally.

I can confirm. I updated the td width locally from 140 to 128 and it works now. Can we get this change merged?

@ferrants
Copy link
Contributor

#156

@d3an d3an closed this as completed Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants