refactor(has_j_send_result_short)!: update constants

marian13 · Sep 10, 2023 · 2074acd · 2074acd
1 parent c7cef07
commit 2074acd
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/lib/convenient_service/service/plugins/has_j_send_result/constants.rb b/lib/convenient_service/service/plugins/has_j_send_result/constants.rb
@@ -11,14 +11,14 @@ module Constants
 
           DEFAULT_SUCCESS_DATA = {}
           DEFAULT_FAILURE_DATA = {}
-          ERROR_DATA = {}
+          DEFAULT_ERROR_DATA = {}
 
-          SUCCESS_MESSAGE = ""
+          DEFAULT_SUCCESS_MESSAGE = ""
           DEFAULT_FAILURE_MESSAGE = ""
           DEFAULT_ERROR_MESSAGE = ""
 
-          SUCCESS_CODE = :success
-          FAILURE_CODE = :failure
+          DEFAULT_SUCCESS_CODE = :default_success
+          DEFAULT_FAILURE_CODE = :default_failure
           DEFAULT_ERROR_CODE = :default_error
         end
       end

diff --git a/spec/lib/convenient_service/service/plugins/has_j_send_result/constants_spec.rb b/spec/lib/convenient_service/service/plugins/has_j_send_result/constants_spec.rb
@@ -36,15 +36,15 @@
       end
     end
 
-    describe "::ERROR_DATA" do
+    describe "::DEFAULT_ERROR_DATA" do
       it "returns empty hash" do
-        expect(described_class::ERROR_DATA).to eq({})
+        expect(described_class::DEFAULT_ERROR_DATA).to eq({})
       end
     end
 
-    describe "::SUCCESS_MESSAGE" do
+    describe "::DEFAULT_SUCCESS_MESSAGE" do
       it "returns empty string" do
-        expect(described_class::SUCCESS_MESSAGE).to eq("")
+        expect(described_class::DEFAULT_SUCCESS_MESSAGE).to eq("")
       end
     end
 
@@ -60,15 +60,15 @@
       end
     end
 
-    describe "::SUCCESS_CODE" do
+    describe "::DEFAULT_SUCCESS_CODE" do
       it "returns `:success`" do
-        expect(described_class::SUCCESS_CODE).to eq(:success)
+        expect(described_class::DEFAULT_SUCCESS_CODE).to eq(:default_success)
       end
     end
 
-    describe "::FAILURE_CODE" do
+    describe "::DEFAULT_FAILURE_CODE" do
       it "returns `:failure`" do
-        expect(described_class::FAILURE_CODE).to eq(:failure)
+        expect(described_class::DEFAULT_FAILURE_CODE).to eq(:default_failure)
       end
     end