Sky shouldn't be visible on low zoom in Globe-Mercator projection

[birkskyum]

When using a globe, and going to a high pitch, the non-globe sky is shown

Demo:
https://cartes.app/?style=transports&choix+du+style=oui#2.08/66.22/-14.38/47/85

[HarelM]

I tent to think this is the sky.
It is best to create a minimal reproduction as it's hard to understand what the style definition is in the linked site...

[birkskyum]

@laem can you help with a minimal repro of the sky issue seen here?

[birkskyum]

@HarelM , repro here , zoom out to see the sky stay in flat-earth mode:
https://codepen.io/birkskyum-1471370946/pen/mdNwGOo

[HarelM]

Thanks @birkskyum!
Globe still doesn't support sky well.
I've linked it in the v5 breaking change issue in order to see if this can be supported as well.

[ibesora]

What are the expectations here? Should we just disable sky? The current implementation tries to simulate sunlight on the earth but that doesn't obviously work on globe

[birkskyum]

I expected the sky to wrap around the globe, so that it starts at the globe edge, and extends out.

[laem]

Thanks for the issue. I've had some problems understanding the sky spec.

I'm still very happy with the globe feature.

Please note that the capture in the initial issue body is a heavily tilted view, as shown by this GIF.

One very easy fix would be to untilt the view at low zoom when the globe projection is set. I'll try to implement that someday.

[birkskyum]

@ibesora , actually, since the "sky" simulate the scattering through the atmosphere like you point to, I agree it doesn't make sense to show it at low zoom when the camera isn't beneath the atmosphere.