Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom new tab page #67

Closed
Jackymancs4 opened this issue Aug 8, 2020 · 3 comments
Closed

Custom new tab page #67

Jackymancs4 opened this issue Aug 8, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Jackymancs4
Copy link

Jackymancs4 commented Aug 8, 2020

Hello @makeworld-the-better-one
I see here:
/~https://github.com/makeworld-the-better-one/amfora/blob/master/display/newtab.go

That you hard coded the content of the new tab page. After a while I almost learned it by memory.

It would be cool if instead the page was loaded from e.g. $HOME/.config/amfora/newtab.gmi (or relative XDG setting). This would allow for higher level of customization, both static (a short list of uber-favourite list of sites), and dynamic (like a cronjob that pipe fortune messages into it).

p.s
The title is not very descriptive. Feel free to rename it.

@makew0rld makew0rld added the enhancement New feature or request label Aug 8, 2020
@makew0rld
Copy link
Owner

This would be a cool feature, thanks. It'd be nice if the page could be cached on startup, but would that break your dynamic idea?

@makew0rld makew0rld changed the title Feature request: file loading of the tab page Custom new tab page Aug 8, 2020
@Jackymancs4
Copy link
Author

but would that break your dynamic idea?

No, not really. It feels like a potentially different newtab page per session (instead of per tab open) is more than enough for cool ideas to emerge.

Still, as potential fix, you could allow the reload function (ctrl-r) to also affect the newtab page.

@makew0rld makew0rld added this to the v1.6.0 milestone Aug 28, 2020
@makew0rld makew0rld added the good first issue Good for newcomers label Aug 31, 2020
@makew0rld makew0rld modified the milestones: v1.6.0, v1.5.0 Sep 1, 2020
@makew0rld
Copy link
Owner

Added by #83, merged into master at 9d7c737. It will be in v1.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants