Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot exit help menu after editing the URL or changing the tab #241

Closed
yaxollum opened this issue Jun 9, 2021 · 2 comments · Fixed by #261
Closed

Cannot exit help menu after editing the URL or changing the tab #241

yaxollum opened this issue Jun 9, 2021 · 2 comments · Fixed by #261
Labels
bug Something isn't working
Milestone

Comments

@yaxollum
Copy link

yaxollum commented Jun 9, 2021

When I open the help page using ? and then I edit the current URL using e and press Enter, I am no longer able to exit the help page using Esc.

This issue also seems to also be present when I open the help page and then try to open a new tab using Ctrl+T, or move to a different tab using F1 or F2, or reload the page using R.

In this situation, the only way (which I know of) to make the help menu go away is to completely exit Amfora.

Is this a bug, or is there something which I'm misunderstanding about the keyboard controls?

@makew0rld
Copy link
Owner

This is a bug, thanks for finding it. It will be fixed for the next release.

@makew0rld makew0rld added the bug Something isn't working label Jun 24, 2021
@makew0rld makew0rld added this to the v1.9.0 milestone Jun 24, 2021
@dvejmz
Copy link
Contributor

dvejmz commented Oct 3, 2021

I'll be happy to take a stab at this bug. I'd also like to submit it as one of my entries for Hacktoberfest 2021. If I were to raise a PR to fix this, would you be happy to allow this issue to be entered into the contest by appending the hacktoberfest-accepted label to the PR, @makeworld-the-better-one ?

I'd like to have a go at this bug either way but doing it as part of Hacktoberfest would mean I'd have to have the PR ready before the end of the month for it to count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants