Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic when subscribing to page #151

Closed
Jackymancs4 opened this issue Dec 21, 2020 · 5 comments
Closed

Panic when subscribing to page #151

Jackymancs4 opened this issue Dec 21, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@Jackymancs4
Copy link

Hello @makeworld-the-better-one
congrats on the new release!

I was trying out the subscription feat. It works well with an atom feed (tested on makeworld.gq) but when subscribing to a page it consistently panics every time, leaving a mess in the terminal.

Windows 10, launched from Powershell

Amfora 1.7.0
Commit: c93d09b
Built by: goreleaser

Screenshot:
WindowsTerminal_2zthca7b2t

Thanks

@makew0rld
Copy link
Owner

Damn, thanks for reporting. m15o reported a similar bug (before the release), with this screenshot:

subscription

I have no issues subscribing to pages on my side, so I assumed they were running off of an older commit and made the release anyway. Looking at the screenshot again, it seem clear they were running off an older commit, as some of the lines referenced don't make sense. For example, subscriptions/subscriptions.go:215 currently just has a comment on it.

The current line actually causing the error appears to be 218, and it happens when you have no entries, then add a feed, close Amfora, and then open it and try to add a page. I have confirmed this error happens on my machine as well. I will fix this ASAP and then make a new release.

@makew0rld makew0rld added the bug Something isn't working label Dec 21, 2020
@makew0rld
Copy link
Owner

makew0rld commented Dec 21, 2020

I have released v1.7.1 with this fix.

@Jackymancs4
Copy link
Author

Nice, I will try the new release on my Windows setup by tomorrow.

@makew0rld
Copy link
Owner

Thanks! I was able to replicate the error and then see the fix, so I don't expect any issues. But testing is always appreciated of course.

@Jackymancs4
Copy link
Author

Indeed, 1.7.1 works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants