-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mediatype handlers #121
Comments
On Unix systems default to using For Windows and macOS do the same, but use the commands used for each OS in For other OSes just raise the error if there's no handlers. The user can override this default catch-all handler with the |
The download modal would still display until the file is entirely downloaded and the application is launched -- except for piped/streamed mediatypes. |
The # This is a special key that defines the handler for all URL schemes for which
# no handler is defined.
other = 'off' Maybe when this feature is added, then that key can be removed and ignored. And instead of displaying an error when the user tries to open an unknown scheme, Amfora will fallback to the default opening command for the user's OS, as mentioned above. If the above happens, there should be a modal that shows up if the user has not explicitly specified a handler, saying "Do you want to try to open a Edit: I'm going to leave this unchanged for now. |
This feature has been added in #134 thanks to @sudobash1, in The CHANGELOG.md file will need to be updated before merging. |
The |
Currently there is support for using different applications per URL scheme, see the
[url-handlers]
section of the config. Another section should be made to support defining a list of mediatypes that the specified application would handle. Currently the only option for binary files (images, audio, etc) is to download it or open it in the portal. Adding this would allow more seamless browsing.The download modal buttons should change to "Open" and "Download". The "Open in Portal" button has always been a bit of a hack.
Example config, using an array of tables
The text was updated successfully, but these errors were encountered: