-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prototype.js: check element has parent node before remove. #35388
Conversation
Hi @EladHeller. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento give me test instance |
Hi @EladHeller. Thank you for your request. I'm working on Magento instance for you. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi @EladHeller, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later. |
@magento run B2B |
Failed to run the builds. Please try to re-run them later. |
@magento run Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Adobe CLA Signed? |
Failed to run the builds. Please try to re-run them later. |
@magento run Adobe CLA Signed |
Failed to run the builds. Please try to re-run them later. |
@EladHeller please, click on the Adobe CLA check link and sign it, thanks! |
837a3b7
to
d138d4d
Compare
No one take care of this PR. I give up. |
Description (*)
Before call to
removeChild
on parent node, check that parent node is not null.If the parent node is null, no action needed.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
document.createElement('div').remove()
Questions or comments
Contribution checklist (*)