Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prototype.js: check element has parent node before remove. #35388

Closed

Conversation

EladHeller
Copy link

@EladHeller EladHeller commented Apr 27, 2022

Description (*)

Before call to removeChild on parent node, check that parent node is not null.
If the parent node is null, no action needed.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Wrong polyfill for HTMLElement.prototype.remove throw error in edge case. #35387

Manual testing scenarios (*)

  1. Browse to Magento 2.4 website.
  2. Open console
  3. Run document.createElement('div').remove()
  4. Expected result: nothing happen.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 27, 2022

Hi @EladHeller. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@EladHeller
Copy link
Author

@magento give me test instance

@magento-deployment-service
Copy link

Hi @EladHeller. Thank you for your request. I'm working on Magento instance for you.

@EladHeller
Copy link
Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-deployment-service
Copy link

Hi @EladHeller, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@EladHeller
Copy link
Author

@magento run B2B

@magento-automated-testing
Copy link

Failed to run the builds. Please try to re-run them later.

@EladHeller
Copy link
Author

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@EladHeller
Copy link
Author

@magento run Adobe CLA Signed?

@magento-automated-testing
Copy link

Failed to run the builds. Please try to re-run them later.

@EladHeller
Copy link
Author

@magento run Adobe CLA Signed

@magento-automated-testing
Copy link

Failed to run the builds. Please try to re-run them later.

@sidolov
Copy link
Contributor

sidolov commented Apr 28, 2022

@EladHeller please, click on the Adobe CLA check link and sign it, thanks!

@sidolov sidolov added the Priority: P3 May be fixed according to the position in the backlog. label Apr 28, 2022
@EladHeller EladHeller force-pushed the fix/remove-prototype branch from 837a3b7 to d138d4d Compare May 1, 2022 11:41
@EladHeller
Copy link
Author

No one take care of this PR. I give up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P3 May be fixed according to the position in the backlog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong polyfill for HTMLElement.prototype.remove throw error in edge case.
2 participants