Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect version check CI #60

Closed
m10rten opened this issue Sep 16, 2022 · 0 comments · Fixed by #62
Closed

Incorrect version check CI #60

m10rten opened this issue Sep 16, 2022 · 0 comments · Fixed by #62
Labels
bug Something isn't working invalid This doesn't seem right javascript Pull requests that update Javascript code

Comments

@m10rten
Copy link
Owner

m10rten commented Sep 16, 2022

Whenever a version is on: lets say: 0.1.0 on NPM
And we try to push a package.json with 0.1.0, it will not fail because it is up to date with NPM.

To fix this: we need to make a new file in the root like we did with replace script file.
then run this in the CI file.
@m10rten m10rten added bug Something isn't working invalid This doesn't seem right question Further information is requested javascript Pull requests that update Javascript code and removed question Further information is requested labels Sep 16, 2022
@m10rten m10rten mentioned this issue Sep 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working invalid This doesn't seem right javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check-ci-version.ts m10rten/validatees
1 participant
@m10rten