-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle context-commentstring setup #4451
fix: handle context-commentstring setup #4451
Conversation
@kylo252 @LostNeophyte I have a few more questions before marking this as ready for review... Should we allow the users to customize this plugin through a table? (for example |
sorry for the delay, we should preferably handle the deprecation gracefully. |
Hey @kylo252! no worries, all good. What do you mean by that? Is there a way to do that? |
check the deprecation handler: /~https://github.com/LunarVim/LunarVim/blob/master/lua%2Flvim%2Fconfig%2F_deprecated.lua#L20 |
Oh! I see.. well I'll try to take a look at that later then. |
I just noticed that this requires a version bump |
@kylo252 added the deprecation message. About the version bump, should I change that somewhere? Also, let me know if there's something else to do on my end. |
f7b4410
to
ffc683e
Compare
I simplified the process: The changes are internal to the setup function, and no further action is required from the user. |
ffc683e
to
45aea10
Compare
Description
This PR fixes a deprecation warning from the
JoosepAlviste/nvim-ts-context-commentstring
plugin.This has been done following the migration steps mentioned in JoosepAlviste/nvim-ts-context-commentstring#82 (comment).
The changes are internal to the setup function, and no further action is required from the user.
All the options under
lvim.builtin.treesitter.context_commentstring
will be directly passed torequire('ts_context_commentstring').setup()
With these changes, we're removing the possibility of customizing the plugin using thelvim.builtin.treesitter
table. So users won't be able to add more languages to the table for example (but I don't know if that's something users usually do). So yes, in theory this is a breaking change.How Has This Been Tested?
comment out these two lines in
lua/lvim/core/treesitter.lua
to trigger the deprecation warning