Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Did basename just break esbuild plugin? #617

Closed
ngdangtu-vn opened this issue Jun 16, 2024 · 1 comment
Closed

Did basename just break esbuild plugin? #617

ngdangtu-vn opened this issue Jun 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ngdangtu-vn
Copy link
Contributor

ngdangtu-vn commented Jun 16, 2024

Version

2.2.1

Platform

linux / ubuntu / tuxedo os 3

What steps will reproduce the bug?

  1. create a folder, let's call frontend/
  2. add frontend/_data.ts with content like this
    export default { basename: '/' }
  3. create main.ts with simple content such as console.log('hello-world')
  4. install esbuild plugin
  5. run deno task serve

How often does it reproduce? Is there a required condition?

always in both build mode and server mode

What is the expected behavior?

The esbuild should build the files then copy the built files to a new path

What do you see instead?

The files (that were meant to be built) got copied to a new path before esbuild can start working on it. In the end, the origin files were copied to the public and the built files are still created in the old relative path under public root.

Additional information

This is a bug because the sass plugin doesn't have this behaviour.

@ngdangtu-vn ngdangtu-vn added the bug Something isn't working label Jun 16, 2024
@oscarotero
Copy link
Member

Thanks for reporting this. I can reproduce this issue and indeed it's a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants