-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: more visually distinct log for url transformation #563
Conversation
Thanks @scarf005 After seeing the screenshots, I think the current problem is in the colors. This is how I see the build log in my computer (macos): ![]() The page url is white and the source file is gray, so it makes easy to distinguish them. But in your terminal, the colors are not applied. Do you have any configuration for that? Can you try if other colors are visible? |
I'm using konsole, and turns out |
Okay, so I propose to modify the |
sounds good, should we also take account for bright themes? |
If it's possible to detect dark/light themes it would be great. |
some terminals like konsole doesn't support dim escape code. Co-authored-by: Oscar Otero <oom@oscarotero.com>
Thank you! |
er, wait, i think this hasn't been properly removed: Lines 146 to 149 in e4a98be
|
Description
Related Issues
resolves #557
Check List
CODE OF CONDUCT
CONTRIBUTING
send multiple pull request.
fmt
to fix the code format before commit.CHANGELOG.md
.