Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extract getOptionsFromCli #540

Merged
merged 2 commits into from
Dec 24, 2023
Merged

refactor: extract getOptionsFromCli #540

merged 2 commits into from
Dec 24, 2023

Conversation

scarf005
Copy link
Contributor

Description

extracts getOptionsFromCli from mod.ts to utils/cli_options.ts for better reusability.

Related Issues

Check List

  • Have you read the
    CODE OF CONDUCT
  • Have you read the document
    CONTRIBUTING
    • One pull request per feature. If you want to do more than one thing,
      send multiple pull request.
    • Write tests. (unneeded)
    • Run deno fmt to fix the code format before commit.
    • Document any change in the CHANGELOG.md.

@oscarotero oscarotero merged commit 4637cfe into lumeland:main Dec 24, 2023
@oscarotero
Copy link
Member

Thank you!

@scarf005 scarf005 deleted the refactor-split-mod branch December 24, 2023 12:04
kwaa added a commit that referenced this pull request Dec 27, 2023
@kwaa
Squashed commit of the following:
5da6b11 
commit d6c9bf4
Author: Oscar Otero <oom@oscarotero.com>
Date:   Sun Dec 24 17:25:35 2023 +0100

    don't update date-fns until Lume 2.1

commit 387b9d7
Author: Oscar Otero <oom@oscarotero.com>
Date:   Sun Dec 24 13:11:42 2023 +0100

    update minify_html

commit 4637cfe
Merge: 0650f0c e1e8509
Author: Óscar Otero <oom@oscarotero.com>
Date:   Sun Dec 24 12:59:47 2023 +0100

    Merge pull request #540 from scarf005/refactor-split-mod

    refactor: extract `getOptionsFromCli`

commit e1e8509
Author: scarf <greenscarf005@gmail.com>
Date:   Sun Dec 24 11:02:29 2023 +0900

    docs: update changelog

commit 0650f0c
Merge: 41c35b6 e23ca35
Author: Óscar Otero <oom@oscarotero.com>
Date:   Sat Dec 23 21:46:03 2023 +0100

    Merge pull request #539 from ngdangtu-vn/core/involve-doc

    rename the first param of Processor callback type

commit e23ca35
Author: Đăng Tú <68631458+ngdangtu-vn@users.noreply.github.com>
Date:   Sun Dec 24 02:59:28 2023 +0700

    rename the first param of Processor callback type

    - fix #538

commit 41c35b6
Author: Oscar Otero <oom@oscarotero.com>
Date:   Sat Dec 23 14:21:53 2023 +0100

    updated dependencies

commit 0f6468c
Author: scarf <greenscarf005@gmail.com>
Date:   Sat Dec 23 12:38:13 2023 +0900

    refactor: extract `getOptionsFromCli`

commit 52d647c
Merge: 83e7f45 0436944
Author: Óscar Otero <oom@oscarotero.com>
Date:   Fri Dec 22 23:25:58 2023 +0100

    Merge pull request #536 from ngdangtu-vn/core/cmt

    improve comments of multilanguage plugin

commit 0436944
Author: Đăng Tú <68631458+ngdangtu-vn@users.noreply.github.com>
Date:   Sat Dec 23 02:29:03 2023 +0700

    improve comments of multilanguage plugin

    + rewrite some comments
    + add table of content comment to clarify the big code block
    + reformat to make the code more consistence

commit 83e7f45
Author: Oscar Otero <oom@oscarotero.com>
Date:   Thu Dec 21 13:51:20 2023 +0100

    temporary workaround to make working the tests

commit eb22561
Author: Oscar Otero <oom@oscarotero.com>
Date:   Thu Dec 21 13:50:59 2023 +0100

    updated deps

commit 12f8dc6
Author: Oscar Otero <oom@oscarotero.com>
Date:   Mon Dec 18 22:45:33 2023 +0100

    merged conflict

commit cb72ce9
Merge: 475a6fe 91b7bb6
Author: Óscar Otero <oom@oscarotero.com>
Date:   Sun Dec 17 19:11:12 2023 +0100

    Merge pull request #531 from ngdangtu-vn/core/log-msg

    add log msg on missing Site instance

commit 91b7bb6
Author: Đăng Tú <68631458+ngdangtu-vn@users.noreply.github.com>
Date:   Sun Dec 17 06:44:00 2023 +0700

    add log msg on missing Site instance

    - add critical log msg on missing Site instance & exit
    - add changelog

commit 475a6fe
Author: Oscar Otero <oom@oscarotero.com>
Date:   Sun Dec 17 16:43:14 2023 +0100

    warn if two pages have the same id, type and lang

commit 7ffccb5
Author: Oscar Otero <oom@oscarotero.com>
Date:   Sat Dec 16 17:38:48 2023 +0100

    better support for netlify identity + decap_cms

commit 547bc74
Author: Oscar Otero <oom@oscarotero.com>
Date:   Sat Dec 16 13:00:47 2023 +0100

    added Lume.PaginateResult

commit 8f34894
Author: Oscar Otero <oom@oscarotero.com>
Date:   Fri Dec 15 20:50:42 2023 +0100

    removed unused dependency

commit 13b1d89
Author: Oscar Otero <oom@oscarotero.com>
Date:   Fri Dec 15 19:42:42 2023 +0100

    fix undefined alternates

commit cb504e4
Author: Oscar Otero <oom@oscarotero.com>
Date:   Fri Dec 15 19:01:07 2023 +0100

    updated changelog

commit 63cabf1
Author: Oscar Otero <oom@oscarotero.com>
Date:   Fri Dec 15 19:00:02 2023 +0100

    improved multilanguage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split core functionality in mod.ts
2 participants
@scarf005 @oscarotero