[InstCombine] Add assumption to preserve deref info after sinking. #120888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhahn
force-pushed
the
ic-deref-assumption
branch
from
7b68352 to
f79dc21
Compare
dtcxzyw
reviewed
Dec 22, 2024
| @@ -2676,6 +2676,8 @@ class IRBuilderBase { | |||
| CallInst *CreateAlignmentAssumption(const DataLayout &DL, Value *PtrValue, | |||
| Value *Alignment, | |||
| Value *OffsetValue = nullptr); | |||
|
|
|||
| CallInst *CreateDereferenceableAssumption(Value *PtrValue, unsigned Size); | |||
There was a problem hiding this comment.
Attribute::getWithDereferenceableBytes uses uint64_t for the size argument.
| @@ -59,16 +59,20 @@ class User; | |||
| class LLVM_LIBRARY_VISIBILITY InstCombinerImpl final | |||
| : public InstCombiner, | |||
| public InstVisitor<InstCombinerImpl, Instruction *> { | |||
| bool CleanupAssumptions = false; | |||
There was a problem hiding this comment.
This option should be taken into account by LastRunTrackingAnalysis.
| Builder.SetInsertPoint(I); | ||
| Value *Ptr = I->getOperand(0); | ||
| Builder.CreateDereferenceableAssumption( | ||
| Ptr, I->getType()->getScalarSizeInBits()); |
There was a problem hiding this comment.
Loads of vectors and pointers are not handled here.
fhahn
force-pushed
the
ic-deref-assumption
branch
from
f79dc21 to
69f4349
Compare
fhahn
force-pushed
the
ic-deref-assumption
branch
from
69f4349 to
b9c785a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.