fix: CLI request handling

bin/porter

@@ -10,11 +10,12 @@ require_once dirname(__DIR__) . '/bootstrap.php';
 
 // Parse CLI request.
 $input = \Porter\Request::instance()->parseCli();
-\Porter\Request::instance()->load($input);
 
-// Router.
-$command = \Porter\Router::run(\Porter\Request::instance());
-call_user_func($command, \Porter\Request::instance());
+// Run if a request was found.
+if (count($input)) {
+    \Porter\Request::instance()->load($input);
+    \Porter\Controller::run(\Porter\Request::instance());
+}
 
 // Console output should end in newline.
 echo "\n";

src/Render.php

@@ -12,12 +12,10 @@ class Render
 {
     /**
      * Output help to the CLI.
-     *
-     * @param Request $request
      */
-    public static function cliHelp(Request $request)
+    public static function cliHelp()
     {
-        $options = $request->getAllOptions(true);
+        $options = Request::instance()->getAllOptions(true);
 
         $output = '';
 

src/Request.php

@@ -170,11 +170,11 @@ public function getOptCodes(array $options): array
      */
     public function parseCli(): array
     {
+        // Short-circuit the help flag.
         global $argv;
-        $command = $argv[1];
-
-        if ($command !== 'run') {
-            return [$command => 1];
+        if ($argv[1] === '--help') {
+            Render::cliHelp();
+            return [];
         }
 
         // Get the options for 'run'.

src/Router.php

@@ -4,7 +4,14 @@
 
 class Router
 {
-    public static function run($request): callable
+    /**
+     * Simple web router.
+     *
+     * @param Request $request
+     *
+     * @return callable
+     */
+    public static function run(Request $request): callable
     {
         switch (true) {
             case $request->get('showsource'): // Single source feature list.
@@ -14,8 +21,6 @@ public static function run($request): callable
                 return '\Porter\Render::viewSourcesTable';
             case $request->get('targets'): // Overview table.
                 return '\Porter\Render::viewTargetsTable';
-            case $request->get('help'): // CLI help.
-                return '\Porter\Render::cliHelp';
             case $request->get('package'): // Main export process.
                 return '\Porter\Controller::run';
             default: // Starting Web UI (index).