Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved mapping results for a multi-part index - merging #189

Closed
wants to merge 24 commits into from

Conversation

hasindu2008
Copy link
Contributor

The following features were added (for uni-segment reads only). The additions were done such that minimal changes are done on existing code.

  1. --multi-prefix option to specify a temporary file prefix
  2. Dumping the internal state of each mapping to temporary files
  3. Merging the intermediate values to generate the final output (merged headers, fixed mapq, fixed flags and the printing of the correct number of the secondary mappings/unaligned reads)

Tested using two datasets 33k reads and 3.9M synthetic long reads. Tested to confirm that the changes do not affect the existing result (see the attached evaluate_accuracy.zip)

evaluate_accuracy.zip

1
2
3
4

@lh3
Copy link
Owner

lh3 commented Jun 24, 2018

Thanks so much for this. I will review and merge later, definitely getting this ready for the next release 2.12.

@lh3 lh3 added this to the 2.12 milestone Jun 24, 2018
@lh3
Copy link
Owner

lh3 commented Jul 15, 2018

Learning from your code, I have reimplemented the support of multi-part index at the split branch. The new option is --split-prefix, which has the same behavior as your --multi-prefix. If you have time, you may test it. I will merge this branch to "master" once I confirm it is stable.

@lh3
Copy link
Owner

lh3 commented Jul 16, 2018

I have merged the split branch to master. I will close this PR. If you find bugs in the new feature, please create an issue. Thank you very much for this PR. It has been very helpful.

@lh3 lh3 closed this Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants