Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: rename "structure-like" to "non-rec structure" #5891

Open
kmill opened this issue Oct 31, 2024 · 1 comment
Open

RFC: rename "structure-like" to "non-rec structure" #5891

kmill opened this issue Oct 31, 2024 · 1 comment
Labels
P-medium We may work on this issue if we find the time RFC accepted RFC is waiting for a corresponding PR (external or internal) RFC Request for comments

Comments

@kmill
Copy link
Collaborator

kmill commented Oct 31, 2024 •
edited
Loading

This RFC is tracking a suggestion by Leo in this comment to rename the "structure-like" concept to "non-rec structure" to prevent confusion in the future.

This would involve:

  • renaming isStructureLike to isNonRecStructure (and is_structure_like to is_non_rec_structure in the kernel)
  • renaming matchConstStructureLike to matchConstNonRecStructure
  • and tracking down all other places "structure-like" appear.
@kmill kmill added the RFC Request for comments label Oct 31, 2024
@kmill kmill mentioned this issue Oct 31, 2024
Merged
@Kha Kha added the RFC accepted RFC is waiting for a corresponding PR (external or internal) label Nov 8, 2024
@Kha
Copy link
Member

Kha commented Nov 8, 2024

RFC accepted

@Kha Kha added the P-medium We may work on this issue if we find the time label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-medium We may work on this issue if we find the time RFC accepted RFC is waiting for a corresponding PR (external or internal) RFC Request for comments
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kha @kmill