Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'o1'/o3-mini model which has become GA (General Availability) on Azure OpenAI #13177

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

deephbz
Copy link
Contributor

@deephbz deephbz commented Feb 4, 2025

Summary

This allows user to select o1 model when using Azure OpenAI model provider.

will close #13231

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. ⚙️ feat:model-runtime labels Feb 4, 2025
@deephbz deephbz changed the title Add 'o1' model which has become GA (General Availability) on Azure OpenAI Add 'o1'/o3-mini model which has become GA (General Availability) on Azure OpenAI Feb 4, 2025
@deephbz deephbz force-pushed the feature/azure-o1-model branch from 8ef0376 to da3b7b0 Compare February 4, 2025 03:11
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 4, 2025
@kurokobo
Copy link
Contributor

kurokobo commented Feb 4, 2025

There are parameters in parameter_rules that are not supported by o1 , and I don't think llm.py will work without modification. Have you actually been able to test this PR using AOAI's o1?

@crazywoola crazywoola mentioned this pull request Feb 5, 2025
83 tasks
@deephbz
Copy link
Contributor Author

deephbz commented Feb 5, 2025

There are parameters in parameter_rules that are not supported by o1 , and I don't think llm.py will work without modification. Have you actually been able to test this PR using AOAI's o1?

I'll test it a bit and get back. Making this PR WIP for now.

There's no ETA yet. If anyone want to pick it up it's welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feat:model-runtime size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Azure OpenAI newer o1/o3 models
2 participants