Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display command output on failure #166

Closed
greg0ire opened this issue Oct 3, 2021 · 2 comments · Fixed by #169
Closed

Display command output on failure #166

greg0ire opened this issue Oct 3, 2021 · 2 comments · Fixed by #169
Assignees
Labels
dependencies Pull requests that update a dependency file Enhancement
Milestone

Comments

@greg0ire
Copy link

greg0ire commented Oct 3, 2021

Feature Request

Q A
New Feature yes
RFC yes
BC Break no

Summary

Right now, potentially helpful output of external programs is not displayed on error, making it hard to troubleshoot them: /~https://github.com/doctrine/orm/runs/3782157355?check_suite_focus=true#step:4:18

I can think of 2 solutions:

  • catch the exception, and wrap it with another that includes the result of $e->getOutput() and $e->getErrorOutput()
  • file an issue on azjezz/psl so that the output is included in the exception's error message.

Cc @azjezz

@azjezz
Copy link
Contributor

azjezz commented Oct 3, 2021

file an issue on azjezz/psl so that the output is included in the exception's error message.

If you think that's a good idea, we can do it, i don't think it would count as a BC break 🤔

The reason i didn't do it initially is that it could result in a messy output + it might expose information that you do not want to be exposed ( especially when used in a web app and you don't have a proper error handler configured )

@greg0ire
Copy link
Author

greg0ire commented Oct 3, 2021

I think that's a good idea yes! Having it configurable for security-concerned people would be a plus!

@greg0ire greg0ire closed this as completed Oct 3, 2021
@greg0ire greg0ire reopened this Oct 3, 2021
@Ocramius Ocramius added this to the 1.13.0 milestone Oct 3, 2021
@Ocramius Ocramius added the dependencies Pull requests that update a dependency file label Oct 3, 2021
@Ocramius Ocramius self-assigned this Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants