Skip to content

Commit

Permalink
docker/podman fail on non-amd64 systems
Browse files Browse the repository at this point in the history
  • Loading branch information
medyagh committed May 9, 2020
1 parent 271ca3a commit 24971a5
Show file tree
Hide file tree
Showing 5 changed files with 26 additions and 3 deletions.
4 changes: 4 additions & 0 deletions pkg/minikube/registry/drvs/docker/docker.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ func configure(cc config.ClusterConfig, n config.Node) (interface{}, error) {

func status() registry.State {
docURL := "https://minikube.sigs.k8s.io/docs/drivers/docker/"
if runtime.GOARCH != "amd64" {
return registry.State{Error: fmt.Errorf("doker driver is not supported on %q systems yet",runtime.GOARCH ), Installed: false, Healthy: false, Fix: "Try other drivers", Doc: docURL}
}

_, err := exec.LookPath(oci.Docker)
if err != nil {
return registry.State{Error: err, Installed: false, Healthy: false, Fix: "Install Docker", Doc: docURL}
Expand Down
4 changes: 4 additions & 0 deletions pkg/minikube/registry/drvs/podman/podman.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@ func configure(cc config.ClusterConfig, n config.Node) (interface{}, error) {

func status() registry.State {
docURL := "https://minikube.sigs.k8s.io/docs/drivers/podman/"
if runtime.GOARCH != "amd64" {
return registry.State{Error: fmt.Errorf("podman driver is not supported on %q systems yet", runtime.GOARCH), Installed: false, Healthy: false, Fix: "Try other drivers", Doc: docURL}
}

podman, err := exec.LookPath(oci.Podman)
if err != nil {
return registry.State{Error: err, Installed: false, Healthy: false, Fix: "Install Podman", Doc: docURL}
Expand Down
3 changes: 3 additions & 0 deletions site/content/en/docs/drivers/docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ The Docker driver allows you to install Kubernetes into an existing Docker insta

## Known Issues

- Docker driver is not supported on non-amd64 architectures such as arm yet. For non-amd64 archs please use [other drivers]({{< ref "/docs/drivers/" >}}

- On macOS, containers might get hung and require a restart of Docker for Desktop. See [docker/for-mac#1835](/~https://github.com/docker/for-mac/issues/1835)

- The `ingress`, `ingress-dns` and `registry` addons are currently only supported on Linux. See [#7332](/~https://github.com/kubernetes/minikube/issues/7332) and [#7535](/~https://github.com/kubernetes/minikube/issues/7535)
Expand All @@ -28,6 +30,7 @@ The Docker driver allows you to install Kubernetes into an existing Docker insta
`sudo mkdir /sys/fs/cgroup/systemd && sudo mount -t cgroup -o none,name=systemd cgroup /sys/fs/cgroup/systemd`.



## Troubleshooting

[comment]: <> (this title is used in the docs links, don't change)
Expand Down
6 changes: 4 additions & 2 deletions site/content/en/docs/drivers/includes/docker_usage.inc
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## Install Docker
## Requirements

- [Docker](https://hub.docker.com/search?q=&type=edition&offering=community&sort=updated_at&order=desc)
- [Install Docker](https://hub.docker.com/search?q=&type=edition&offering=community&sort=updated_at&order=desc)
- amd64 system.

## Usage

Expand All @@ -14,3 +15,4 @@ To make docker the default driver:
```shell
minikube config set driver docker
```

12 changes: 11 additions & 1 deletion site/content/en/docs/drivers/podman.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,14 @@ aliases:
This driver is experimental and in active development. Help wanted!
{{% /pageinfo %}}

The podman driver is another kubernetes in container driver for minikube. similar to [docker](https://minikube.sigs.k8s.io/Drivers/docker/) driver. The podman driver is experimental, and only supported on Linux and macOS (with a remote podman server)
The podman driver is another kubernetes in container driver for minikube. similar to [docker](https://minikube.sigs.k8s.io/Drivers/docker/) driver. The podman driver is experimental, and only supported on Linux and macOS (with a remote podman server).



## Requirements
- amd64 system
- Latest version of [Podman](https://podman.io/getting-started/installation)


## Try it with CRI-O container runtime.

Expand All @@ -20,3 +27,6 @@ minikube start --driver=podman --container-runtime=cri-o
```

{{% readfile file="/docs/drivers/includes/podman_usage.inc" %}}

## Known Issues
- Podman driver is not supported on non-amd64 architectures such as arm yet. For non-amd64 archs please use [other drivers]({{< ref "/docs/drivers/" >}}

0 comments on commit 24971a5

Please sign in to comment.