Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable enableServiceLinks feature in NFD master pod #883

Closed
eero-t opened this issue Sep 5, 2022 · 4 comments · Fixed by #1045
Closed

Disable enableServiceLinks feature in NFD master pod #883

eero-t opened this issue Sep 5, 2022 · 4 comments · Fixed by #1045
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@eero-t
Copy link

eero-t commented Sep 5, 2022

What would you like to be added:

spec.enableServiceLinks: false to nfd-master service pod spec.

Why is this needed:

See: kubernetes/kubernetes#92615

(Kubernetes itself is not going to default that to false as that would break its core API compatibility, so each service pod should set that option when service is accessed by its "[.]" DNS name instead of env var IP address.)

@eero-t eero-t added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 5, 2022
@marquiz
Copy link
Contributor

marquiz commented Sep 6, 2022

Why not. Even though we're not expecting to see thousands of services in the nfd namespace

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 5, 2022
@eero-t
Copy link
Author

eero-t commented Dec 7, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 7, 2022
@AhmedGrati
Copy link

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants