Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved metrics #1275

Closed
marquiz opened this issue Jul 21, 2023 · 1 comment · Fixed by #1290
Closed

Improved metrics #1275

marquiz opened this issue Jul 21, 2023 · 1 comment · Fixed by #1290
Assignees
@marquiz
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@marquiz
Copy link
Contributor

marquiz commented Jul 21, 2023

What would you like to be added:

Additional metrics that are missing in the initial implementation (#1242)

  • error counters (on nfd-master):
    • node update errors
    • NodeFeatureRule processing errors
  • counters of denied/filtered out properties
    • invalid/rejected labels
    • invalid/rejected extended resources
    • invalid/rejected taints

Why is this needed:

Improved observability, make it possible to spot error scenarios from metrics.
@marquiz marquiz added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 21, 2023
@marquiz marquiz mentioned this issue Jul 21, 2023
Closed
@marquiz
Copy link
Contributor Author

marquiz commented Jul 28, 2023

/assign

@marquiz marquiz mentioned this issue Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marquiz marquiz

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metrics: additional metrics for nfd-master marquiz/node-feature-discovery
1 participant
@marquiz