Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly pass TypeMeta through AdmissionReviews #499

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Correctly pass TypeMeta through AdmissionReviews #499

merged 1 commit into from
Apr 19, 2021

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Apr 19, 2021

Somehow didn't catch this is my testing. Adds a test to make sure this can't happen again.

clux
clux approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thank you. Was trying to find how that could occur myself!

@clux clux merged commit 9ce6413 into kube-rs:master Apr 19, 2021
@coadler coadler deleted the fix-admission-typemeta branch April 19, 2021 22:27
@clux clux mentioned this pull request May 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clux clux clux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coadler @clux