Refactor kube-derive using darling #435
Conversation
kazk
force-pushed
the
refactor-derive-with-darling
branch
from
a6a739d to
55f0a7d
Compare
kazk
force-pushed
the
refactor-derive-with-darling
branch
from
55f0a7d to
0209892
Compare
| status: Option<String>, | ||
| #[darling(multiple, rename = "shortname")] | ||
| shortnames: Vec<String>, |
There was a problem hiding this comment.
You'll get a nice error like this:
There was a problem hiding this comment.
Oo, that's nice. Assume this is using rust-analyzer?
There was a problem hiding this comment.
I'm using rust-analyzer, but "did you mean" is darling's feature /~https://github.com/TedDriggs/darling/blob/d128844d71445bef93c6449612d16d6dc28625e8/core/src/error/kind.rs#L175
There was a problem hiding this comment.
Yeah, it was more that RA sometimes has issues with certain derive macros for me. But if this works fine then that's great.
|
|
||
| /// Values we can parse from #[kube(attrs)] | ||
| #[derive(Debug, Default)] | ||
| #[derive(Debug, Default, FromDeriveInput)] | ||
| #[darling(attributes(kube))] | ||
| struct KubeAttrs { |
There was a problem hiding this comment.
This is awesome. Gets rid of so much code, and darling seems pretty light on dependencies as well. Great clean-up.
|
kind ci is a false negative. I am happy to merge. |
|
I started looking into better tests (#179) and have some nice tests for failures using /~https://github.com/dtolnay/trybuild. I'll push it soon. |
| @@ -0,0 +1,23 @@ | |||
| error: Missing field `group` | |||
There was a problem hiding this comment.
Shows errors from all the missing required attributes (not stopping at group anymore)
| @@ -0,0 +1,5 @@ | |||
| error: Enums or Unions can not #[derive(CustomResource)] | |||
There was a problem hiding this comment.
Noticed the error message was missing ] thanks to this test.
|
All green now 🎉 Please merge if the new tests looks good. |
|
I noticed a typo in a test file name... |
|
hah, was just about to hit the button |
kazk
force-pushed
the
refactor-derive-with-darling
branch
from
1f59214 to
21d6754
Compare
| // If you make a change, remove `tests/ui/*.stderr` and run `cargo test`. | ||
| // Then copy the files that appear under `wip/` if it's what you expected. | ||
| // Alternatively, run `TRYBUILD=overwrite cargo test`. | ||
| // See /~https://github.com/dtolnay/trybuild |
|
Same false negative, will try to fix that in #437. Happy to merge. |
|
Released in 0.51.0 :-) |
Make parsing macro inputs declarative with
darling.See the diff (only the first commit that refactors) ignoring whitespace.