-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: emscripten-core/emscripten
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.28.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: emscripten-core/emscripten
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.29.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 9 commits
- 12 files changed
- 3 contributors
Commits on Dec 17, 2014
-
Update and enable embind tests to run with the Closure Compiler
This change adds a pass to the embind tests to run them with the Closure Compiler enabled. Because embind.test.js will be passed through the Closure Compiler, name- mangling will occur on unquoted references to embound classes and functions. However, because embound symbols are exposed via string literals, this results in a mismatch. The tests have now been updated so that all references to embound symbols are referred to by string literals (i.e. object["property"] syntax) instead of just by name (i.e. object.property syntax). A set of Closure externs for Underscore were also added, because Underscore (which is used by the embind test adapter) exposes some symbols by string literal as well.
Configuration menu - View commit details
-
Copy full SHA for ef73471 - Browse repository at this point
Copy the full SHA ef73471View commit details -
Update embind to work with Closure Compiler
Several names within the embind JavaScript itself need to be guarded from name mangling in the Closure Compiler. With this commit, the embind tests will now pass in the Closure Compiler test phase.
Configuration menu - View commit details
-
Copy full SHA for 1ea1a63 - Browse repository at this point
Copy the full SHA 1ea1a63View commit details
Commits on Jan 5, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 912dab0 - Browse repository at this point
Copy the full SHA 912dab0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6badff6 - Browse repository at this point
Copy the full SHA 6badff6View commit details
Commits on Jan 6, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 91b4908 - Browse repository at this point
Copy the full SHA 91b4908View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4301fa6 - Browse repository at this point
Copy the full SHA 4301fa6View commit details
Commits on Jan 7, 2015
-
Configuration menu - View commit details
-
Copy full SHA for d49c338 - Browse repository at this point
Copy the full SHA d49c338View commit details -
Merge pull request #3084 from rharkeadsk/dev/embind-closure
Update embind to work with the Closure Compiler
Configuration menu - View commit details
-
Copy full SHA for aacbf97 - Browse repository at this point
Copy the full SHA aacbf97View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe3ff5a - Browse repository at this point
Copy the full SHA fe3ff5aView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1.28.3...1.29.0