Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla NodeJS require no longer works in v2.5.1 #125

Closed
hdavidzhu opened this issue Mar 16, 2020 · 4 comments
Closed

Vanilla NodeJS require no longer works in v2.5.1 #125

hdavidzhu opened this issue Mar 16, 2020 · 4 comments

Comments

@hdavidzhu
Copy link

hdavidzhu commented Mar 16, 2020

/~https://github.com/share/sharedb-mingo-memory/blob/81b5c3ba0434e231e4a7f5219ef9ddb783d96f52/index.js#L1

This type of import now breaks w/ the latest patch.

Repro:

const mingo = require('mingo')
console.log(mingo)
❯ node index.js
internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module 'mingo'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/Users/dzhu/lever/tmp-lol/index.js:1:15)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
@hdavidzhu hdavidzhu changed the title Direct require no longer works in v2.5.1 Vanilla NodeJS require no longer works in v2.5.1 Mar 16, 2020
@kofrasa
Copy link
Owner

kofrasa commented Mar 16, 2020

Hey @hdavidzhu,

Really sorry for breaking the nodeJS require. Will take a look very soon.

@marklapointe
Copy link

Thanks for the heart attack.

@kofrasa
Copy link
Owner

kofrasa commented Mar 16, 2020

Tracked down the issue. Will publish 2.5.2 to address it

@hdavidzhu
Copy link
Author

@kofrasa Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants