Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to delete default mappers for a ldap user federation resource #730

Closed

Conversation

gerbermichi
Copy link
Contributor

This pull requests resolve the issue #729.

The property default_mappers was added to the keycloak_ldap_user_federation indicating whether the default mappers should be created or not. The default is true.

Closes #729

…ult mappers which are normally created by keycloak.
@mrparkers
Copy link
Contributor

Hey @gerbermichi, thanks for opening this PR. I had a few changes I wanted to make, but I was unable to push them to your branch, so I opened #744 for them.

Here's a summary of the changes:

  • I removed the usage of the ComponentType structs nested within each mapper struct. I understand that you did this so you could genericize the deletion of these mappers, but the component struct was already used for a similar purpose, so I just re-implemented the deletion logic within the keycloak package and invoked it from the provider package.
  • I renamed the new attribute to delete_default_mappers, because it feels better for the user to explicitly opt-in for this behavior.
  • I added a test for this change

I'm going to close this in favor of #744. It'll be included within the next release, which I want to get out by the end of the week.

@mrparkers mrparkers closed this Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to delete default mappers for a ldap user federation resource
2 participants