Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Swin Transformer Model #671

Open
tanzhenyu opened this issue Aug 6, 2022 · 14 comments
Open

Support Swin Transformer Model #671

tanzhenyu opened this issue Aug 6, 2022 · 14 comments

Comments

@tanzhenyu
Copy link
Contributor

Related to #668, this is another transformer based model which we'd like to be supported. For simplicity, focus on only classification task, having in mind that future detection tasks might rely on it.

For contributors, please follow the contribution guide.

And specifically, on the API Design Guide, we'd like to see a brief description of how the model would look like before implementation, preferrably conforming to the tf.keras.application style.

@ariG23498
Copy link
Contributor

I would like to work on this!

@ariG23498
Copy link
Contributor

Hey @tanzhenyu

I got around reading the contriution guideline and the API design document. I was unable to find a guide to contribute a model inside of keras_cv.

My main doubts:

  • Do we need to port the weights of the model (here SwinT in PyTorch)? If yes (which I hope should be the case), how would I do that?
  • Do we also need to validate the weight porting process by validating it wrt the task (classification here) on a benchmark dataset?
  • How do we check the correctness of the model?

@bhack
Copy link
Contributor

bhack commented Aug 6, 2022

Hey @tanzhenyu

I got around reading the contriution guideline and the API design document. I was unable to find a guide to contribute a model inside of keras_cv.

My main doubts:

  • Do we need to port the weights of the model (here SwinT in PyTorch)? If yes (which I hope should be the case), how would I do that?
  • Do we also need to validate the weight porting process by validating it wrt the task (classification here) on a benchmark dataset?
  • How do we check the correctness of the model?

It would be useful to have something like:
/~https://github.com/keras-team/keras/blob/master/CONTRIBUTING.md#contributing-to-keras-applications

@bhack
Copy link
Contributor

bhack commented Aug 6, 2022

Also, do we have a duplicate ticket with #636 ?

@tanzhenyu
Copy link
Contributor Author

Hey @tanzhenyu

I got around reading the contriution guideline and the API design document. I was unable to find a guide to contribute a model inside of keras_cv.

My main doubts:

  • Do we need to port the weights of the model (here SwinT in PyTorch)? If yes (which I hope should be the case), how would I do that?
  • Do we also need to validate the weight porting process by validating it wrt the task (classification here) on a benchmark dataset?
  • How do we check the correctness of the model?

Yes we do expect porting the weights and verifying the results against the original paper. For the guide, @bhack 's reference is most relevant.

@ayulockin
Copy link

@ariG23498 will you mind if I join you on this PR?

@ariG23498
Copy link
Contributor

I have no issues collaborating with you on this one!

@bhack
Copy link
Contributor

bhack commented Oct 13, 2022

Yes we do expect porting the weights and verifying the results against the original paper. For the guide, @bhack 's reference is most relevant.

We have @sayakpaul /~https://github.com/sayakpaul/swin-transformers-tf for this

Then we need to build the training phase.

@DavidLandup0
Copy link
Contributor

To do transformer-based models we'll need new layers (reusable) and blocks (might be reusable). KerasCV is currently missing blocks to rapidly build transformer-based models. Might be worth taking a detour to work on those components first

@ayulockin
Copy link

I agree with @DavidLandup0.

@tanmaypandey7
Copy link

tanmaypandey7 commented Jan 8, 2023

Hi! Are you guys @ayulockin and @ariG23498 still working on this? I would like to help if it's alright.

@IMvision12
Copy link
Contributor

Is Anyone working on this??

Copy link

This issue is stale because it has been open for 180 days with no activity. It will be closed if no further activity occurs. Thank you.

@sachinprasadhs
Copy link
Collaborator

Thanks for reporting the issue! We have consolidated the development of KerasCV into the new KerasHub package, which supports image, text, and multi-modal models. Please read keras-team/keras-hub#1831. KerasHub will support all the core functionality of KerasCV.

KerasHub can be installed with !pip install -U keras-hub. Documentation and guides are available at keras.io/keras_hub.

With our focus shifted to KerasHub, we are not planning any further development or releases in KerasCV. If you encounter a KerasCV feature that is missing from KerasHub, or would like to propose an addition to the library, please file an issue with KerasHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants