Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: APIExportEndpointSlice reconciliation #2332

Closed
1 task done
fgiloux opened this issue Nov 9, 2022 · 1 comment
Closed
1 task done

feature: APIExportEndpointSlice reconciliation #2332

fgiloux opened this issue Nov 9, 2022 · 1 comment
Assignees
@fgiloux
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@fgiloux
Copy link
Contributor

fgiloux commented Nov 9, 2022 •
edited
Loading

Feature Description

This feature request follows #2331

The aim is the implementation of the APIExportEndpointSlice reconciliation. As a first step its status should get populated with the endpoints for all the Shards of the referenced APIExport

Proposed Solution

API design

Alternative Solutions

Alternatives have been discussed in this Google doc

Want to contribute?

  • I would like to work on this issue.

Additional Context

No response

Additional Tasks

Follow-ups of #2432

  • Permissions: The export reference must not expose existence of an APIExport or even the target workspace. Plus, we have to validate that you own the export (content subresource).
  • Add end-to-end tests
  • Switch all existing uses of the endpoints in APIExport to APIExportEndpointSlice.
@fgiloux fgiloux added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 9, 2022
@fgiloux fgiloux added this to kcp Nov 9, 2022
@fgiloux fgiloux moved this to New in kcp Nov 9, 2022
@fgiloux fgiloux mentioned this issue Nov 9, 2022
Closed
1 task
@fgiloux fgiloux changed the title feature: APIExportSlice reconciliation feature: APIExportEndpointSlice reconciliation Nov 15, 2022
This was referenced Nov 18, 2022
Merged
Merged
@fgiloux fgiloux self-assigned this Nov 21, 2022
@fgiloux fgiloux moved this from New to In Progress in kcp Nov 29, 2022
@fgiloux fgiloux mentioned this issue Nov 30, 2022
Merged
@fgiloux fgiloux moved this from In Progress to In Review in kcp Dec 9, 2022
@fgiloux fgiloux mentioned this issue Jan 6, 2023
Merged
@fgiloux fgiloux moved this from In Review to Done in kcp Jan 10, 2023
@fgiloux fgiloux moved this from Done to In Review in kcp Jan 10, 2023
@fgiloux fgiloux mentioned this issue Jan 12, 2023
Merged
@fgiloux
Copy link
Contributor Author

fgiloux commented Jan 30, 2023

Closing as

  • the feature functionalities have been implemented
  • an admission webhook has been created for checking permissions
  • end-to-end tests have been added
  • there is no reference on the server side to the endpoints in APIExports.

@fgiloux fgiloux closed this as completed Jan 30, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in kcp Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fgiloux fgiloux

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
kcp
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fgiloux