Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Toggle Catalog and Code Editor #217

Closed
kahboom opened this issue Feb 14, 2022 · 1 comment
Closed

Toggle Catalog and Code Editor #217

kahboom opened this issue Feb 14, 2022 · 1 comment
Assignees
Labels
enhancement Improve existing features good first issue Good for newcomers

Comments

@kahboom
Copy link
Contributor

kahboom commented Feb 14, 2022

Description

When the YAMLEditor (code editor) is selected, the Catalog should be collapsed, and vice versa. This would prevent them from being overlapped, which makes the YAMLEditor unusable when the Catalog is opened.

2022-03-02 at 13 34 29 - Lime Weasel

We can't move the Catalog to the right side of the screen, because that's where the StepDetail panel is.

This could also be a good opportunity to move the YAMLEditor into the PatternFly Drawer, instead of being part of the Grid system it's in now. This is what the Catalog does--it opens up as an overlay above the Visualization. This allows you to open the Catalog without it moving the Visualization canvas.

The YAMLEditor, using the Grid system now:

2022-03-02 at 13 49 40 - Harlequin Grasshopper

By contrast, when using a Drawer like the Catalog does, it's an overlay and doesn't alter the position of the Visualization canvas when it's opened.

2022-03-02 at 13 43 10 - Amaranth Orangutan

Steps

  • Add conditional to DrawerContent to show either the catalog or code editor
  • Move the code editor into the conditional
  • Adjust the Grid for the Visualization, or remove it altogether if it's not necessary.

References

@kahboom kahboom added enhancement Improve existing features good first issue Good for newcomers labels Feb 14, 2022
@kahboom kahboom added this to the Sprint Zero milestone Feb 14, 2022
@kahboom kahboom removed this from the Sprint Zero milestone May 3, 2022
@kahboom
Copy link
Contributor Author

kahboom commented Jun 8, 2022

Closing as we'll likely be doing a redesign.

@kahboom kahboom closed this as completed Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improve existing features good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants