Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runn loadt gets stuck on GitHub Actions #1149

Closed
mi-wada opened this issue Jan 10, 2025 · 2 comments · Fixed by #1150
Closed

runn loadt gets stuck on GitHub Actions #1149

mi-wada opened this issue Jan 10, 2025 · 2 comments · Fixed by #1150
Assignees
Labels
bug Something isn't working

Comments

@mi-wada
Copy link
Contributor

mi-wada commented Jan 10, 2025

Problem

When running runn loadt on GitHub Actions, it doesn't finish. Therefore it meets GitHub Actions timeout, and fail CI. I tried on ubuntu-latest and macos-latest, same results.
exec log: /~https://github.com/mi-wada/tmp_runn_load_test_stuck_on_gh_actions/actions/runs/12704061252

.github/workflows/test.yaml
name: Test
on:
  push:
    branches:
      - main
  pull_request:
defaults:
  run:
    shell: bash
concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: true
jobs:
  test_on_ubuntu_latest:
    runs-on: ubuntu-latest
    timeout-minutes: 1
    steps:
      - uses: actions/checkout@v4
      - name: Install runn
        env:
          RUNN_VERSION: v0.122.3
        run: |
          RUNN_BIN_URL="/~https://github.com/k1LoW/runn/releases/download/${RUNN_VERSION}/runn_${RUNN_VERSION}_linux_amd64.tar.gz"
          curl -sL -o runn.tar.gz "$RUNN_BIN_URL"
          tar -xvf runn.tar.gz
          sudo mv runn /usr/local/bin/
      - run: |
          runn run hello_world.yaml --scopes run:exec
      - run: |
          runn loadt hello_world.yaml --scopes run:exec
  test_on_macos_latest:
    runs-on: macos-latest
    timeout-minutes: 1
    steps:
      - uses: actions/checkout@v4
      - name: Install runn
        run: |
          brew install k1LoW/tap/runn
          runn --version
      - run: |
          runn run hello_world.yaml --scopes run:exec
      - run: |
          runn loadt hello_world.yaml --scopes run:exec
hello_world.yaml
desc: Hello, World!
steps:
  - exec:
      command: echo "Hello, World!"

reproduced repo: /~https://github.com/mi-wada/tmp_runn_load_test_stuck_on_gh_actions/blob/main/.github/workflows/test.yaml

Expected behavior

Finish after about 10 secs as a default duration.

My investigation log

  • The command runn loadt hello_world.yaml --scopes run:exec works well on my MacBook.
  • Maybe these lines are the cause. I run only these lines on GitHub Actions, it also meets timeout. exec log
    • runn/cmd/loadt.go

      Lines 93 to 101 in 1f373ba

      p := tea.NewProgram(newSpinnerModel())
      go func() {
      _, _ = p.Run()
      }()
      if err := ot.Start(ctx); err != nil {
      return err
      }
      p.Quit()
      p.Wait()
@k1LoW k1LoW self-assigned this Jan 10, 2025
@k1LoW k1LoW added the bug Something isn't working label Jan 10, 2025
@k1LoW
Copy link
Owner

k1LoW commented Jan 10, 2025

@mi-wada Thank you for your report! I'll check it.

@mi-wada
Copy link
Contributor Author

mi-wada commented Jan 14, 2025

Updating to the fixed version v0.127.1 has fixed our problem. Thank you so much for your speedy resolution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants